RF: rename variables in ROI selection loops

[matthew-brett]

Rename variables for clarity, as proposed in
#422

[matthew-brett]

By the way, I think https://github.com/nipy/nipy/blob/master/nipy/labs/spatial_models/mroi.py#L689 must be wrong - the self variable will get rebound, and so have no effect on the self in the method signature. You'd need to set the properties / attributes of self directly.

[coveralls]

Coverage remained the same at 86.604% when pulling e6f347b on matthew-brett:refactor-mroi into 2e0871e on nipy:master.

[codecov-io]

Codecov Report

Merging #423 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   83.18%   83.18%   +<.01%     
==========================================
  Files         299      299              
  Lines       28077    28084       +7     
  Branches     3270     3270              
==========================================
+ Hits        23356    23363       +7     
  Misses       3719     3719              
  Partials     1002     1002

Impacted Files	Coverage Δ
nipy/labs/spatial_models/tests/test_mroi.py	97.56% <100%> (+0.1%)	✅
nipy/labs/spatial_models/mroi.py	57.99% <100%> (+0.31%)	✅

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0871e...ac17468. Read the comment docs.

[matthew-brett]

I added a fix and test for the select_roi bug.

[coveralls]

Coverage increased (+0.003%) to 86.607% when pulling ac17468 on matthew-brett:refactor-mroi into 2e0871e on nipy:master.

[matthew-brett]

@VirgileFritsch - any comment here?

[VirgileFritsch]

That's fine. Thank you Matthew :)

[matthew-brett]

Thanks - in it goes.