MRG: Extend testing, fix / simplify interpolation #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 83.00% 83.02% +0.02%
==========================================
Files 306 306
Lines 28441 28448 +7
Branches 3303 3304 +1
==========================================
+ Hits 23608 23620 +12
+ Misses 3825 3821 -4
+ Partials 1008 1007 -1
Continue to review full report at Codecov.
|
Extend testing of prefiltered interpolation. This revealed various bugs: * Prefiltering=False of linear interpolation was failing, because the prefilter=False option didn't make sense - because we were (correctly) not prefiltering. * Use more standard TemporaryFile for backing store to avoid errors from too many open files. * Avoid padding before prefiltering for Scipy < 1.6, because this gives different results from non-prefiltered case.
matthew-brett
force-pushed
the
testing-interpolate
branch
from
1cd8bba
to
dfbac87
Compare
|
I think this is the right fix, with extra tests, for the issue in #478 - as well as a couple of extra issues I found during testing. |
|
Last call for a review here? |
effigies
approved these changes
Mar 10, 2021
|
Thanks Chris. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend testing of prefiltered interpolation.
This revealed various bugs:
prefilter=False option didn't make sense - because we were (correctly)
not prefiltering.
too many open files.
different results from non-prefiltered case.
Also see #478