Improve const-correctness in C code #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 297 297
Lines 27590 27590
Branches 3361 3361
=======================================
Hits 23370 23370
Misses 3266 3266
Partials 954 954 ☔ View full report in Codecov by Sentry. |
effigies
approved these changes
Dec 23, 2023
Since it returns void *, which is implicitly convertible to any data pointer type, explicitly casting the result only adds clutter and repetition.
Fixes a number of warnings.
effigies
force-pushed
the
const-correctness
branch
from
56cf7a8
to
608c6c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit “Do not cast the result of PyArray_DATA()” is in this PR because it touches most of the same lines that needed to be touched to fix const-related warnings.
I’d like to suggest that a broader change to stop explicitly casting
void *return values could make sense; I claim that they add clutter and repetition but don’t reduce errors. They are not required becausevoid *happily converts implicitly to any data pointer type (in C, not C++). Such a change would affect at leastmalloc(),calloc(),realloc(), andPyArray_ITER_DATA(). However, I don’t want to get that tangled up with the const-correctness changes, especially if it’s not desired.