Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Encoding problems in SGE plugin #1624

Closed
wants to merge 5 commits into from

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Sep 12, 2016

Fixes #1621

@codecov-io
Copy link

codecov-io commented Sep 14, 2016

Codecov Report

Merging #1624 into master will increase coverage by 0.14%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
+ Coverage   70.63%   70.77%   +0.14%     
==========================================
  Files        1016     1020       +4     
  Lines       50928    51649     +721     
  Branches     7238     7365     +127     
==========================================
+ Hits        35971    36554     +583     
- Misses      13894    14012     +118     
- Partials     1063     1083      +20
Flag Coverage Δ
#smoketests 52.55% <16.66%> (-0.01%) ⬇️
#unittests 70.52% <16.66%> (+0.17%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/traits_extension.py 97.26% <100%> (ø) ⬆️
nipype/pipeline/plugins/sge.py 17.67% <11.76%> (-0.51%) ⬇️
nipype/algorithms/tests/test_confounds.py 96.66% <0%> (-3.34%) ⬇️
nipype/interfaces/afni/base.py 65.59% <0%> (-1.08%) ⬇️
nipype/pipeline/plugins/tests/test_multiproc.py 66.06% <0%> (-0.61%) ⬇️
nipype/algorithms/compcor.py 100% <0%> (ø)
nipype/algorithms/tests/test_auto_ComputeDVARS.py 85.71% <0%> (ø)
nipype/algorithms/tests/test_tsnr.py 100% <0%> (ø)
nipype/algorithms/tests/test_compcor.py 100% <0%> (ø)
nipype/testing/utils.py 93.42% <0%> (+4.33%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9a751...abf7e48. Read the comment docs.

@oesteban oesteban changed the title [FIX, WIP] Encoding problems in SGE plugin [FIX] Encoding problems in SGE plugin Sep 14, 2016
@@ -147,7 +147,7 @@ def _qacct_verified_complete(taskid):
while qacct_retries > 0:
qacct_retries -= 1
try:
strtaskid = '{0!d}'.format(taskid)
strtaskid = '{0:d}'.format(int(taskid))
proc = subprocess.Popen(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i switched this to CommandLine in the slurm plugin - take a look there. CommandLine handles most encoding issues properly.

@oesteban oesteban closed this Oct 12, 2017
@oesteban oesteban deleted the fix/issue-1625 branch November 29, 2017 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants