-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Encoding problems in SGE plugin #1624
Conversation
42b3254
to
a570796
Compare
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
+ Coverage 70.63% 70.77% +0.14%
==========================================
Files 1016 1020 +4
Lines 50928 51649 +721
Branches 7238 7365 +127
==========================================
+ Hits 35971 36554 +583
- Misses 13894 14012 +118
- Partials 1063 1083 +20
Continue to review full report at Codecov.
|
@@ -147,7 +147,7 @@ def _qacct_verified_complete(taskid): | |||
while qacct_retries > 0: | |||
qacct_retries -= 1 | |||
try: | |||
strtaskid = '{0!d}'.format(taskid) | |||
strtaskid = '{0:d}'.format(int(taskid)) | |||
proc = subprocess.Popen( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i switched this to CommandLine
in the slurm plugin - take a look there. CommandLine
handles most encoding issues properly.
Fixes #1621