REF refactor algorithms misc.py #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 70.87% (diff: 97.79%)@@ master #1631 diff @@
==========================================
Files 1020 1019 -1
Lines 51240 51240
Methods 0 0
Messages 0 0
Branches 7259 7259
==========================================
+ Hits 36314 36318 +4
+ Misses 13840 13837 -3
+ Partials 1086 1085 -1
|
berleant
changed the title
| @@ -35,6 +34,7 @@ | |||
| BaseInterfaceInputSpec, isdefined, | |||
| DynamicTraitedSpec, Undefined) | |||
| from ..utils.filemanip import fname_presuffix, split_filename | |||
| from . import confounds | |||
There was a problem hiding this comment.
This can be problematic. If you need some interface from confounds, please import that one interface only.
Sorry, you are right on that this is possibly the cleanest way to implement the deprecation warning.
chrisgorgo
requested changes
Sep 14, 2016
| """ | ||
| def __init__(self, **inputs): | ||
| super(confounds.TSNR, self).__init__(**inputs) | ||
| warnings.warn(("This interface has been deprecated since 0.12.0," |
There was a problem hiding this comment.
Could we say moved instead of deprecated? "deprecated" suggest that functionality has changed
chrisgorgo
approved these changes
Sep 14, 2016
oesteban
added a commit
that referenced
this pull request
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1613
Nice-to-have pre #1628 (so it will be neater)