Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add LTA output to BBRegister #2031

Merged
merged 1 commit into from May 18, 2017
Merged

Conversation

effigies
Copy link
Member

To make up for over-eager issue closing. This PR adds out_lta_file to the BBRegister interface.

Set min_ver=5.2.0 based on this tag.

Fixes #266

@codecov-io
Copy link

codecov-io commented May 18, 2017

Codecov Report

Merging #2031 into master will decrease coverage by <.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
- Coverage    72.2%   72.19%   -0.01%     
==========================================
  Files        1132     1132              
  Lines       57024    57032       +8     
  Branches     8165     8167       +2     
==========================================
+ Hits        41173    41175       +2     
- Misses      14567    14572       +5     
- Partials     1284     1285       +1
Flag Coverage Δ
#smoketests 72.19% <22.22%> (-0.01%) ⬇️
#unittests 69.79% <22.22%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...ype/interfaces/freesurfer/tests/test_BBRegister.py 77.77% <ø> (ø) ⬆️
nipype/interfaces/freesurfer/preprocess.py 64.84% <22.22%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90cfdd8...ab826ef. Read the comment docs.

@@ -1171,6 +1173,7 @@ class BBRegisterInputSpec6(BBRegisterInputSpec):
class BBRegisterOutputSpec(TraitedSpec):
out_reg_file = File(exists=True, desc='Output registration file')
out_fsl_file = File(desc='Output FLIRT-style registration file')
out_lta_file = File(desc='Output FLIRT-style registration file')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would call this LTA-style

@effigies
Copy link
Member Author

Updated descriptions in input and output specs.

@satra satra merged commit cda3fdc into nipy:master May 18, 2017
@effigies effigies deleted the enh/bbregister_lta branch May 18, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants