Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add 3dSynthesize, -cbucket flag for 3dDeconvolve #2210

Merged
merged 4 commits into from Oct 8, 2017
Merged

[ENH] Add 3dSynthesize, -cbucket flag for 3dDeconvolve #2210

merged 4 commits into from Oct 8, 2017

Conversation

emdupre
Copy link
Contributor

@emdupre emdupre commented Oct 5, 2017

Changes proposed in this pull request

  • Add a nipype wrapper for the AFNI command 3dSynthesize
  • Add the cbucket flag to existing nipype wrapper of 3dDeconvolve for use with 3dSynthesize

@codecov-io
Copy link

codecov-io commented Oct 5, 2017

Codecov Report

Merging #2210 into master will increase coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2210      +/-   ##
==========================================
+ Coverage   72.31%   72.32%   +<.01%     
==========================================
  Files        1179     1180       +1     
  Lines       58821    58849      +28     
  Branches     8465     8469       +4     
==========================================
+ Hits        42535    42561      +26     
- Misses      14910    14911       +1     
- Partials     1376     1377       +1
Flag Coverage Δ
#smoketests 72.32% <93.33%> (ø) ⬆️
#unittests 69.88% <93.33%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...pype/interfaces/afni/tests/test_auto_Deconvolve.py 85.71% <100%> (ø) ⬆️
nipype/interfaces/afni/model.py 85.45% <100%> (+1.34%) ⬆️
nipype/interfaces/afni/__init__.py 100% <100%> (ø) ⬆️
...pype/interfaces/afni/tests/test_auto_Synthesize.py 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b10ff2...8fe85ab. Read the comment docs.

@satra
Copy link
Member

satra commented Oct 6, 2017

@emdupre - this looks good. however, we just merged some changes that is going to change the auto-test outputs. could you please merge with master, run make specs, and push again?

@satra satra merged commit cee5db9 into nipy:master Oct 8, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants