Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SerialWorker Implementation #507

Merged
merged 7 commits into from
Jan 28, 2022
Merged

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Oct 27, 2021

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Updates the implementation of serial worker so that it works with latest version of Pydra

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #507 (8033ff7) into master (4db192a) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   78.42%   78.60%   +0.18%     
==========================================
  Files          20       20              
  Lines        4305     4301       -4     
  Branches     1218     1217       -1     
==========================================
+ Hits         3376     3381       +5     
+ Misses        733      725       -8     
+ Partials      196      195       -1     
Flag Coverage Δ
unittests 78.53% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/specs.py 88.13% <ø> (ø)
pydra/engine/workers.py 18.62% <100.00%> (+0.79%) ⬆️
pydra/engine/submitter.py 84.66% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db192a...8033ff7. Read the comment docs.

@tclose tclose marked this pull request as ready for review January 20, 2022 11:45
@tclose
Copy link
Contributor Author

tclose commented Jan 20, 2022

The only test that is failing is a SLURM one that appears to be unrelated to my changes. I’m assuming it was introduced when I last merged the master.

@djarecka if you have a moment to look at the PR it would be great to have it merged in for the next micro release if possible (so I can release another version of arcana that depends on them)

@djarecka
Copy link
Collaborator

@tclose - i thought that reruning the test will help, but it didn't. I will run/debug the test on our local slurm and see.

@tclose
Copy link
Contributor Author

tclose commented Jan 27, 2022

@djarecka seems like rerunning the tests did the trick on the second attempt. Is it okay to merge now?

@djarecka
Copy link
Collaborator

that's great! Thank you!

@djarecka djarecka merged commit 1100d7c into nipype:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants