-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More descriptive debugging graph errors and bugfix in values validator #581
Conversation
Codecov ReportBase: 77.13% // Head: 76.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
==========================================
- Coverage 77.13% 76.72% -0.42%
==========================================
Files 20 19 -1
Lines 4330 4331 +1
Branches 1217 1225 +8
==========================================
- Hits 3340 3323 -17
- Misses 802 821 +19
+ Partials 188 187 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@djarecka do you know why this would be failing the SLURM check? I don't think I changed anything that would impact on it
|
@tclose - this test is flaky, perhaps I should do more reruns, before reporting fails. I wonder if you had some test cases that you were testing this on and could be added to the repo? |
I fixed the "real" case that was failing but I have been meaning to create a test with an incorrectly designed task, which will trigger this case |
ok, I will merge this now, so it is in the newest release. I'm sure this will be an update to the previous error report. I've created an issue to think about the tests: #590 |
Types of changes
Summary
_allowed_values_validator
now accepts LazyField objectsChecklist