[wip] new graph class #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing issues with some results being None
…r.__call__ that overwrites runnable.cache_locations, and adding a test for workflow; adding sleep time for some arguments to add2 functions (just to have some variability in the execution time)
node/task tests and adding cache_locations to __call__
…ne checks if all the tasks from the graph are done, not if we can find results of the wf); WIP: trying to eliminate self.__dict__.update(nwf.__dict__) - it works for runnable with state, not sure why it doesn't work without state...
…ionary updates from run_task; moving submit_async to the Submitter; some test don't work because output_dir is changing (TODO)
…created for output), changing checksum property so it's not recalculated during the workflow execution; adding tests for using the cachedresults for workflows with state that use entirely or partially previously computed outpu
…ving run to a private method
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
+ Coverage 81.42% 84.33% +2.9%
=========================================
Files 11 13 +2
Lines 1976 2145 +169
Branches 496 531 +35
=========================================
+ Hits 1609 1809 +200
+ Misses 284 250 -34
- Partials 83 86 +3
Continue to review full report at Codecov.
|
|
will open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is combination of the changes from #60 and #51 . will wait for #51 merge
they are only small changes needed to
Workflow