Modify changed type name: uri → url #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested changes
May 29, 2018
| @@ -19,7 +19,7 @@ syn keyword NirumPrimitiveNumberType bigint decimal int32 int64 float32 float64 | |||
| syn keyword NirumPrimitiveStringType text binary | |||
| syn keyword NirumPrimitiveTimeType datetime date | |||
| syn keyword NirumPrimitiveBoolType bool | |||
| syn keyword NirumPrimitiveEtcType uuid uri | |||
| syn keyword NirumPrimitiveEtcType uuid url | |||
There was a problem hiding this comment.
Until the minor version of the Nirum compiler (0.4.0), both names coexist. Could we highlight deprecated or obsolete keywords in a different way from others? E.g., red background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
urichanged its name tourlon Nirum 0.4.0, It has to be applied to syntax highlighter as well.Please review this PR. @dahlia