Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named and multiple arguments for annotations #190

merged 3 commits into from Oct 30, 2017


Copy link

@dahlia dahlia commented Oct 29, 2017

As #178 suggested, I made annotation arguments multiple. To simplify the rule unnamed arguments became unsupported; thus every argument has its parameter name. @docs, an internal annotation that represents docs comments, also have a parameter named docs. Annotations without parentheses are equivalent to zero arguments.

Also wrote some docs about annotations. I believe the docs is enough substitution of explanation for this pull request.

@dahlia dahlia self-assigned this Oct 29, 2017
@dahlia dahlia requested review from kanghyojun and Kroisse Oct 29, 2017
@dahlia dahlia mentioned this pull request Oct 29, 2017
4 of 8 tasks complete
@dahlia dahlia force-pushed the dahlia:annotation-multiple-parameters branch from 5448d1d to 7aba046 Oct 29, 2017
dahlia added a commit to dahlia/nirum-python that referenced this pull request Oct 29, 2017
@dahlia dahlia merged commit e1de9b2 into nirum-lang:master Oct 30, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants