Upgrade to Stackage LTS Haskell 10.7 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
added
typ:bug
Checklist 🤔
|
|
I will review this PR at weekend. |
dahlia
force-pushed
the
stack-lts-10.7
branch
2 times, most recently
from
345f22b
to
cb736ee
Compare
dahlia
force-pushed
the
stack-lts-10.7
branch
2 times, most recently
from
11ca711
to
2c30256
Compare
> Error: While constructing the build plan, the following exceptions were encountered: > In the dependencies for turtle-1.4.5: > Win32-2.5.4.1 from stack configuration does not match >=2.2.0.1 && <2.4 (latest matching version > is 2.3.1.1) > needed due to nirum-0.3.0 -> turtle-1.4.5 > Some potential ways to resolve this: > * Recommended action: try adding the following to your extra-deps > in C:\projects\nirum-k5n5y\stack.yaml: > - Win32-2.3.1.1 > * Set 'allow-newer: true' to ignore all version constraints and build anyway. > * You may also want to try using the 'stack solver' command. > Plan construction failed. [changelog skip]
|
@admire93 All builds are now passed. Could you review this? |
kanghyojun
approved these changes
Mar 3, 2018
| # - ignore: {name: Use let} | ||
| # - ignore: {name: Use const, within: SpecialModule} # Only within certain modules | ||
| - ignore: | ||
| name: Reduce duplication |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a retrial of PR #214, which ended up unsuccessful. Since the patch became more complicated in the end than I'd expected, here some points I give you:
-optP-Wno-nonportable-include-pathoption toghc-optionson macOS to work around Cabal's this bug: Filename case on macOS haskell/cabal#4739. See also a comment I left in package.yaml.-Wallflags toghc-optionsfor manylibrary/executables/testsentries to give an-Wno-missing-signaturesoption toghc-optionsforspectest (it's an entry for unit tests). The global-Wallflag seems to override all entry-local-Wno-*flags.-Wno-missing-signaturesis basically only for thespectest entry.-fhide-source-pathsoption so I applied it to stack.yaml.