Render the site menu based on user configuration #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hugo supports menus defined in config.toml, as well as the frontmatter. We can iterate through Sites.Menu.<menu_name> to generate the site menu, although my implementation doesn't support nested menus. I also changed the example site to use the new menu implementation, while keeping the previous menu ordering and generated CSS classes. Please see https://gohugo.io/extras/menus/ for details.
According to https://gohugo.io/content/multilingual/, a theme should either use .URL or construct URLs using relLangURL/absLangURL - not both. Cocoa doesn't support multiple languages yet, so this was probably harmless.
nishanths
reviewed
Mar 25, 2017
There was a problem hiding this comment.
@lpancescu Thank you for the changes!
Looks good to merge, but could you address the comment before?
layouts/partials/header.html
Outdated
| <li class="nav-blog"><a href="/blog/">Blog</a></li> | ||
| <li class="nav-about"><a href="/about/">About</a></li> | ||
| <li class="nav-code"><a href="/code/">Code</a></li> | ||
| {{ $currentPage := . }} |
There was a problem hiding this comment.
Is this assignment useful? Can we remove it if it's not?
It is probably better to define the site menu in the configuration file, instead of spreading it over the content files (especially if we have to order the menu items by using the weight parameter). The only disadvantage is that the menu isn't automatically updated when you remove a section or fixed page from the content.
|
@nishanths I removed the unused assignment and refactored the example site to define the menu structure just in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hugo supports menus defined in config.toml, as well as the frontmatter.
We can iterate through Sites.Menu.<menu_name> to generate the site menu,
although my implementation doesn't support nested menus.
I also changed the example site to use the new menu implementation,
while keeping the previous menu ordering and generated CSS classes.
Please see https://gohugo.io/extras/menus/ for details.