Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computes action space from available interventions, pre-specified planning and built interventions #72

Closed
wants to merge 9 commits into from
Closed

Computes action space from available interventions, pre-specified planning and built interventions #72

wants to merge 9 commits into from

Conversation

willu47
Copy link
Member

@willu47 willu47 commented Jun 8, 2017 •
edited
Loading

[Delivers #146797149]

  • Uses set operations on intervention names to compute state and action space
  • Assumes intervention names are unique identifiers (is this safe @tomalrussell?)
  • Builds decision vector from action space, parses decision vector and returns list of interventions

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.65% when pulling 3785085 on feature/decision/state into 84a7143 on master.

@willu47
Copy link
Member Author

willu47 commented Jun 8, 2017

[Delivers #146704439]
[Delivers #146797149]
[Delivers #146791009]

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.631% when pulling 76d5150 on feature/decision/state into 84a7143 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.631% when pulling 2f8be3e on feature/decision/state into ae0bedb on master.

@willu47 willu47 requested a review from tomalrussell June 8, 2017 18:30
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.291% when pulling 95ad746 on feature/decision/state into ae0bedb on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.291% when pulling 961952b on feature/decision/state into ae0bedb on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.392% when pulling c5dad2a on feature/decision/state into 7cfd332 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.39% when pulling 4f00096 on feature/decision/state into 7cfd332 on master.

willu47
willu47 commented Jun 14, 2017
View reviewed changes
smif/sos_model.py
state = self.get_state(model, timestep)
self.logger.info("Running model %s for timestep %s",
model.name, timestep)
state, decisions = self.get_state(timestep, model.name)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguments are reversed...

@willu47 willu47 closed this Jun 22, 2017
@tomalrussell tomalrussell deleted the feature/decision/state branch December 13, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalrussell tomalrussell Awaiting requested review from tomalrussell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willu47 @coveralls