Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Ambiguous project name error while restoring NuGet packages. #1027

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Feb 25, 2023

When I had tried to build NPOI.sln with VS2022, I always got Ambiguous project name 'NPOI' error while restoring NuGet packages. Therefore, I was able able to test only NPOI.Core build until recently.

After some search I found NuGet/Home#7372 that says all csproj files should have unique or empty PackageId.

So I removed all <PackageId>NPOI</PackageId> settings from csproj files to resolve the ambiguous project name error.

@tonyqus
Copy link
Member

tonyqus commented Feb 25, 2023

Looks the following files also need to be changed. Can you update them as well?

  • NPOI.OOXML.Core.csproj
  • NPOI.OpenXml4Net.Core.csproj
  • NPOI.OpenXmlFormats.Core.csproj

@tonyqus tonyqus added this to the NPOI 2.6.1 milestone Feb 25, 2023
@tonyqus tonyqus added the bug label Feb 25, 2023
@9rnsr
Copy link
Contributor Author

9rnsr commented Feb 26, 2023

The *.Core.csproj files didn't have the problem, so we don't need to change them.

@tonyqus
Copy link
Member

tonyqus commented Feb 26, 2023

LGTM

@tonyqus tonyqus merged commit a84f39c into nissl-lab:master Feb 26, 2023
@9rnsr
Copy link
Contributor Author

9rnsr commented Feb 26, 2023

Thanks!

@9rnsr 9rnsr deleted the fix_csproj_PackageId branch March 5, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants