Build process maintenance 3rd #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
In `NPOI.Test.sln` I got internal errors during test case search with the combination of VS2022 + NUnit3TestAdapter 4.2.1, then I cannot execute any test cases those are listed in Test Explorer. To fix the error, update NUnit3TestAdapter version to 4.3.1 . In `NPOI.Core.Test.sln`, the problem didn't happen, but I also update NUnit3TestAdapter for consistency.
9rnsr
force-pushed
the
build_maintenance3
branch
from
2e1b691
to
db55ee6
Compare
…work csprojs Microsoft.SourceLink.GitHub --> 1.1.1 (in `Directory.Build.props`) NSubstitute --> 4.2.2 NUnit --> 3.13.3
9rnsr
force-pushed
the
build_maintenance3
branch
from
db55ee6
to
27e9661
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next of #1031.
Make tests runnable for .NET Framework v4.7.2 with VS2022
In
NPOI.Test.slnI got internal errors during test case search with the combination of VS2022 + NUnit3TestAdapter 4.2.1, then I cannot execute any test cases those are listed in Test Explorer.To fix the error, update NUnit3TestAdapter version to 4.3.1 .
In
NPOI.Core.Test.sln, the problem didn't happen, but I also update NUnit3TestAdapter for consistency.Update NuGet packages versions for consistency between Core and Framework csprojs
Microsoft.SourceLink.GitHub --> 1.1.1 (in
Directory.Build.props)NSubstitute --> 4.2.2
NUnit --> 3.13.3