Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception cleanup #1034

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Exception cleanup #1034

merged 3 commits into from
Feb 28, 2023

Conversation

mycroes
Copy link
Contributor

@mycroes mycroes commented Feb 27, 2023

Change following exception behavior:

  1. Remove Exception rethrows (CA2200 violations)
  2. Remove redundant handling of IOException
  3. Replace Exception catch without capture with untyped catch clause

Michael Croes added 3 commits February 27, 2023 21:55
Remove exception rethrows (CA2200)
94ebcc7 
Also remove redundant try-catches (catching and rethrowing only).
Remove redundant IOException handling
a3b95c2 
Identical handling on Exception is right below.
Replace Exception catches without capture with untyped catch clauses
5df3482
@mycroes mycroes mentioned this pull request Feb 27, 2023
Open
@tonyqus
Copy link
Member

tonyqus commented Feb 28, 2023

LGTM

@tonyqus tonyqus added this to the NPOI 2.6.1 milestone Feb 28, 2023
@tonyqus tonyqus merged commit 57f985a into nissl-lab:master Feb 28, 2023
@mycroes mycroes deleted the exception-cleanup branch February 28, 2023 07:00
@mycroes mycroes mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mycroes mycroes

Labels
enhancement
Projects
None yet
Milestone
NPOI 2.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mycroes @tonyqus