-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build process maintenance 4th #1037
Conversation
03facaa
to
79769c6
Compare
I fixed the failure of AppVeyor build (Internal server error). |
I don't think merge Core csproj and non-Core csproj is a good idea. I remember there are some test cases behaving differently between Core and non-Core mode. |
Today, tests in Core csprojs only targets net6.0, but we can easily add one more target framework net472. |
If there is no reasons other than the test behavior, I prefer to use SDK style csprojs for maintainability. |
I'll evaluate if it's possible to merge Core csproj and non-Core csproj. The situation is different from before. NPOI doesn't need to support .NET framework 2.x/3.x anymore. The difference may have became very tiny. |
Remove dependency to System.Web assembly that belongs to ASP.NET.
0ac4f99
to
515a3ab
Compare
LGTM |
Thanks! |
This pull request introduced a regression. Look at the fix in #1083. |
Related: #1033
Migrate csproj for net472 to SDK style.
Add TargetFramework net427 to *.Core.csproj files, then remove old style csprojs.
Fix troublesome manual .runsettings file specification for testing.
Add default runsettings file and use it by adding
<RunSettingsFilePath>
setting inDirectory.Build.props
.After the SDK style csproj migrations, any tests built for all
TargetFramework
s will have same relative filepaths to the required test data. Therefore we can have onetest.runsettings
file at the root of repository.