Update SXSSFRow.cs #1073
Merged
Update SXSSFRow.cs #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```Height``` returns the combined value of the current row height and the ```Sheet.DefaultRowHeight```. ```_height``` returns the value of the row height. Therefore I propose to use the row height here. This code triggers although there is no custom row height set: https://github.com/nissl-lab/npoi/blob/4997d06aeb603359bab3cc9653cd03840a1dcfa4/ooxml/XSSF/Streaming/SheetDataWriter.cs#L229-L234
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heightreturns the combined value of the current row height and theSheet.DefaultRowHeight._heightreturns the value of the row height.Therefore I propose to use the row height here.
This code triggers although there is no custom row height set:
npoi/ooxml/XSSF/Streaming/SheetDataWriter.cs
Lines 229 to 234 in 4997d06