Include all projects in NuGet package #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
refine-nuget-package
branch
2 times, most recently
from
deab769
to
0df1dad
Compare
lahma
force-pushed
the
refine-nuget-package
branch
2 times, most recently
from
7716efd
to
1ec86ee
Compare
lahma
force-pushed
the
refine-nuget-package
branch
from
1ec86ee
to
15e31d8
Compare
|
I guess this is now as good as I can get it. Ready for trials. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a separate
NPOI.Pack.csprojproject that references other projects and thus creates a NuGet package that has all dependencies inside. This changesNPOI.dllto beNPOI.Core.dll(like the project actually is) in order for pack to succeed. Uses Nugetizer reference which fixes project references to be also part of NuGet package contents.Ideally there would be separate NuGet packages for each on NuGet or as now there's build output (dll and pdb) for each dependency multiple times in package output. The package size is now 11MB which is quite big but that's the way to roll I guess with current setup where Core is/was packaging target and reverse-dependencies are needed.
With Nugetizer there's no snupkg anymore sore pdbs are part of the main NuGet package.