Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on comparing value types to null #1141

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

karakasa
Copy link
Contributor

@karakasa karakasa commented Jul 30, 2023

RT

looks like incorrect porting from Java to C# / from Hashtable to Dictionary.

@tonyqus
Copy link
Member

tonyqus commented Aug 11, 2023

LGTM

@tonyqus tonyqus merged commit a77b0b9 into nissl-lab:master Aug 11, 2023
2 of 3 checks passed
@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Aug 11, 2023
@karakasa karakasa deleted the fix_compare_to_null_bug branch August 12, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants