Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package publish logic #1173

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Improve package publish logic #1173

merged 1 commit into from
Aug 26, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Aug 26, 2023

  • include release* branches
  • read version from branch name if starts with release
  • change output from artifacts to publish (artifacts will be used by NET 8 for binaries)

As i used release1.5.1 (an imaginary version) as my branch name, you can see that the build on my fork determined this to be publish build and forced all version information from the branch name, output from ubuntu-latest run:

06:13:26 [INF] BUILD SETUP
06:13:26 [INF] 	Solution: /home/runner/work/npoi/npoi/solution/NPOI.Core.Test.sln
06:13:26 [INF] 	Configuration: Release
06:13:26 [INF] 	Version suffix: 
06:13:26 [INF] 	Publish version: 1.5.1
06:13:26 [INF] Build environment:
06:13:26 [INF] 	Host: Nuke.Common.CI.GitHubActions.GitHubActions

The summary has the Artifacts at the bottom https://github.com/lahma/npoi/actions/runs/5983250670 which opens a zip file containing a NuGet package versioned as 1.5.1 and passes all NuGet checks:

image

So with these changes you should be able to get NuGet release branch from any release branch automatically as long as branch name starts with release.

* include release* branches
* read version from branch name
* change output from artifacts to publish (artifacts will be used by NET 8 for binaries)
@tonyqus
Copy link
Member

tonyqus commented Aug 26, 2023

LGTM

@tonyqus tonyqus merged commit 0dcf605 into nissl-lab:master Aug 26, 2023
3 checks passed
@tonyqus
Copy link
Member

tonyqus commented Sep 1, 2023

The CI works great! It's really a life saver. Thank you!

I'm impressed that it can even automatically update dependency packages for the nuget package.

@lahma lahma deleted the release1.5.1 branch September 2, 2023 12:10
@lahma
Copy link
Collaborator Author

lahma commented Sep 2, 2023

So nice to hear! When it's scripted and automated, it's usually reproducible and and has expect results (release build, exactly known sources etc).

@tonyqus tonyqus added this to the NPOI 2.6.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants