-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DefaultColumnWidth #1181
Fix DefaultColumnWidth #1181
Conversation
This PR fixes DefaultColumnWidth type and implementation. Due to POI bug it returned baseColumnWidth, which is integer. This is a breaking change. Fixes nissl-lab#943
This seems to be incorrect: when retrieving column width we should check first if the column width is set, otherwise if |
Would it just make more sense in the test case ( Assert.False(File.Exists(tempFile));
Assert.False(File.Exists(tempFile2)); |
Yes, this test can be rewritten, but then another IO-dependent test can fail. We need to resolve it globally |
I wouldn't trust the I'd say removing the attribute and adjusting the test case to check for specific items would be the way to go. Some cleanup logic could go somewhere like assembly fixture teardown. |
LGTM |
This PR fixes DefaultColumnWidth type and implementation. Due to POI bug it returned baseColumnWidth, which is integer. This is a breaking change.
Fixes #943