Update samples and packages #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update samples and NPOI version to 2.5.1
|
Some projects are still referencing Ionic.Zip package. It's not used anymore. Can you help remove it from the projects? |
|
@tonyqus, sorry, missed it. I've a question about examples: right now some examples targeting to .NET Framework 4.0, and another one to .NET 4.5. Will it be better to retarget them all to .NET Framework 4.0 as a least supported .NET Framework by NPOI? |
|
I suggest retargetting all to .NET 4.5 since most nuget package are stopping .NET framework 4 support. Sooner or later NPOI will only support 4.5. To avoid duplicate work, 4.5 is prefered |
|
done |
Bykiev
changed the title
|
Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update samples and NPOI version to 2.5.1