Pivot tables serialization fixes #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 30, 2022 11:41
Some namespaces were missing in pivot table related objects.
Pivot area property was serializing wrong, omiting "field" property when it has value of 0, which causes excel to repair the pivot tables that contain this object. Added WriteAttribute reload for string values, to accept a default string in method call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed CT_CustomFilters and CT_CustomFilter classes and their usage in AutoFilter
Added namespaces to pivot tables definition: xmlns:mc, mc:Ignorable, xmlns:xr. Changed some nodes serialization in pivot table parts, to conform with ECMA standard XSD of OOXML.
Added reload for XmlHelper.WriteAttribute for string type values, that can accept a default value, to decide if this attribute should be present in stream or it can be omitted.
Pivot area property was serializing wrong, omitting "field" property when it has value of 0, which causes excel to repair the pivot tables that contain this object.