Fix delete and add chart throws exception #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 29, 2022 11:13
The method checks for existing chat names, and gets the firtst chart number that isnt in use yet.
For ease of chart removal.
Improve TestRemoveOneOfTwoChartsAndAddNewOne test.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new chart was created it's number was determined by the number of previously existing charts. This created a bug, when there were charts chart1.xml and chart2.xml, chart1 was deleted and the new chart was created. Since there is a chart already (chart2), the number for a new chart would be 2 (CountOfCharts + 1). This will throw an exception, because chart2.xml already exists.
Also added a RemoveChart method to XSSFDrawing and tests for the fixed bug and for the the RemoveChart method