[MRG] Replace 'paradigm' with 'events', 'experimental paradigm' for BIDS compliance #257
Conversation
…radigm' -1 - Replaced \ line continuation with parantheses. - Reformatted multiline ars and expressions. - Changed so 'events' is accessed using dict key, not obj attribute. - Removed paradigm_from_csv() reference in reference.rst (function removed previously)
…mpliance)
- Replaced .csv file extension for events file with .tsv .
- In examples, generally replaced paradigm.to_csv('paradigm.csv') with
events.to_csv('events.tsv', sep='\t', index=False).
- Tweaked documentation language.
- Typo correction.
|
Let me know when it's ready for review. |
kchawla-pi
changed the title
|
It is now ready for review. |
|
Uh circleci is failing. I'll check that, you can start on the review if you wish. In some of your examples (newly merged/updated) I have :
Do double check those. |
|
The error seems similar to what Nilearn experienced: nilearn/nilearn#1763 |
kchawla-pi
changed the title
|
There's one modification in test_utils.py I forgot to make. I'll push that soon. |
- Renaming localizer_paradigm.csv to localizer_events.tsv caused the error. The file is named so on the fetch server and hence cannot be renamed here.
|
The error was occurring because I changed the name of the events file from |
|
Hey @bthirion that's file rename is causing problems right now and I think we have better goals to pursue. So I say we merge it this way. Maybe I can open a new PR to rename the events file tomorrow. WHat do you think? |
kchawla-pi
changed the title
nistats/design_matrix.py
Outdated
| only a simple warning will be displayed. A particular attention should | ||
| be given to the 'trial_type' key which defines the different conditions | ||
| in the paradigm. | ||
| An experimental paradigm is valid if it has an 'onset' key. |
|
Will merge tonight unless I hear otherwise. |
|
FYI: In a few places I replaced events key with events columns. |
|
Merging now. |
issue #216