Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added last_commenter field to topic #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alesdotio
Copy link
Contributor

I'm gonna use this to show who made the last comment on the topic list view.

Just thought you might find it useful.

@coveralls
Copy link

coveralls commented May 28, 2016

Coverage Status

Coverage decreased (-0.04%) to 97.052% when pulling ecb1323 on alesdotio:feature/last_commenter into 9aebbe9 on nitely:master.

@nitely
Copy link
Owner

nitely commented May 29, 2016

It may be. The current UI is ok as it is, IMHO. But I'll rewrite it soon and I may show the topic creator and the last comment creator.

But I dunno. The reason why I'm not showing this kind of info, is coz it's ephemeral. On an active community, refreshing the topic list after a couple seconds/minutes will show a different user, so I don't find it useful. But may be it is for some?

@alesdotio
Copy link
Contributor Author

It's quite common to show when the last post was and who made it. It makes it easier to scan through unread topics. Feel free to close it if you don't need it, it was just something from my fork.

@nitely
Copy link
Owner

nitely commented May 29, 2016

Isn't that solved by the comment count turning red? Is that the only reason
it's useful?

El dom., may. 29, 2016 5:13 PM, Ales Kocjancic notifications@github.com
escribió:

It's quite common to show when the last post was and who made it. It makes
it easier to scan through unread topics. Feel free to close it if you don't
need it, it was just something from my fork.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#123 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABnl833hUPaAC1bNpxUv0eIiJoCeMX5qks5qGfOHgaJpZM4IpB7b
.

@alesdotio
Copy link
Contributor Author

People asked for it, the rest is just my assumptions ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants