-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encoding to work with Cyrillic and Portuguese accentuation #57
Conversation
LGTM. @Shivam010 if there are no objections let's get this in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, LGTM too.
Also, I don't exactly remember why I iterate over all the characters. @breno12321 Did you run all the test cases?
The GitHub action should have run for the pr, right? Why hasn't it run? |
@Shivam010 I created the #58 check if its this what you mean 👀 |
@breno12321 All the tests were successful earlier, have a look here https://github.com/nitishm/go-rejson/runs/2264211335?check_suite_focus=true |
Ah sorry my bad 🙃 I ran in my fork master and failed for some reason 🤔 |
Pull Request Test Coverage Report for Build 1697933704
💛 - Coveralls |
Apparently was related to the rejson version @Shivam010 good to go ✅ 🕺🏼 |
Ok, tests are passing so, I am accepting the changes |
Thanks guys!! Lets continue the journey to learn go hehe |
Context
As we know in the issue #56 some characters when read from the database are not being processing as valid UTF-8 Characters. So this fixes it to handle the full length of the data representation for them
Closes #56