nitcorn: fix bug with binary files #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err then | ||
| last_error = new IOError("Failed to add file at '{path}'") | ||
| file.close | ||
| end |
There was a problem hiding this comment.
quite convoluted, only the FileReaded.open seems necesarry, the initial file_exist is useless since the error will be caugut latter. And the file_stat sould be replaced by a FileStream::stat or something that use the POSIX fstat internally.
There was a problem hiding this comment.
If I'm not mistaken file.file_stat already uses fstat. But l'll remove the file_exist check.
|
+1 |
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
|
Rerolled to remove the |
privat
added a commit
that referenced
this pull request
Nov 7, 2015
Downloading binary files from a nitcorn server works as expected once again. The API should be enough for most users but there is a few features lacking. Namely alternating custom text with files and writing custom data. We could merge the `body` and `files` attributes into a sequence of `Bytables` to send, with support for `Bytes`. You can test the result on xymus.net, either by downloading the latest WBTW at http://xymus.net/pub/wbtw-v0.4-110-g668b261.tar.gz or by playing a clone of Super Hexagon (mostly made by @ablondin) at http://xymus.net/pub/hex/. Pull-Request: #1817 Reviewed-by: Jean Privat <jean@pryen.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading binary files from a nitcorn server works as expected once again.
The API should be enough for most users but there is a few features lacking. Namely alternating custom text with files and writing custom data. We could merge the
bodyandfilesattributes into a sequence ofBytablesto send, with support forBytes.You can test the result on xymus.net, either by downloading the latest WBTW at http://xymus.net/pub/wbtw-v0.4-110-g668b261.tar.gz or by playing a clone of Super Hexagon (mostly made by @ablondin) at http://xymus.net/pub/hex/.