Added UNIX support to nitcorn #2709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested changes
Jun 6, 2018
There was a problem hiding this comment.
While I like the idea of implementing UNIX socket in its own module, I see a lot of duplicated code. You can instead use intrude import reactor to access internal services not exposed in the public nitcorn API.
With this implementation, can you run a server listening on both TCP and UNIX sockets?
| vh.routes.add new Route(null, new FileServer("www/hello_world/")) | ||
|
|
||
| # Set server in UNIX mode | ||
| vh.unix("/tmp/example.sock") |
There was a problem hiding this comment.
Could you just add this line to an existing example?
There was a problem hiding this comment.
Since unix methods are on a separate module, are you sure you don't want to keep this example in a separate file ?
lib/nitcorn/unix.nit
Outdated
| # Handle to retreive the `HttpFactory` on config change | ||
| private var factory: HttpFactory is noinit | ||
|
|
||
| private init with_factory(factory: HttpFactory) do self.factory = factory |
There was a problem hiding this comment.
Isn't this already in reactor?
lib/nitcorn/unix.nit
Outdated
| # Configuration of this server | ||
| # | ||
| # It should be populated after this object has instanciated | ||
| redef var config = new ServerConfig.with_factory(self) |
lib/nitcorn/unix.nit
Outdated
| var unix_path = "" is optional, writable | ||
| # # Has `self` been registered by `listen_on`? | ||
| private var registered = false | ||
|
|
There was a problem hiding this comment.
Please double check the style here.
- Added new module `nitcorn::unix` to add unix support - Added tests&example code for new module `unix` - Multiple dirty redifinitions of reactor's class for unix support (because of dirty redefinity of `Sys` in reactor) - Implementation of unix support for libevent added in PR nitlang#2708 Signed-off-by: Matthieu Le Guellaut <leguellaut.matthieu@gmail.com>
UPDATE
|
privat
added a commit
that referenced
this pull request
Jun 8, 2018
**DO NOT MERGE BEFORE PR #2708** As requested in #2678 - Added new module `nitcorn::unix` to add unix support - Added tests&example code for new module `unix` - Multiple dirty redifinitions of reactor's class for unix support (because of dirty redefinity of `Sys` in reactor) - Implementation of unix support for libevent added in PR #2708 Pull-Request: #2709 Reviewed-by: Alexis Laferrière <alexis.laf@xymus.net>
|
Merged as #2726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE BEFORE PR #2708
As requested in #2678
nitcorn::unixto add unix supportunixSysin reactor)