Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http proxy support #528

Merged
merged 6 commits into from
Jul 4, 2023
Merged

feat: add http proxy support #528

merged 6 commits into from
Jul 4, 2023

Conversation

HomelessDinosaur
Copy link
Member

@HomelessDinosaur HomelessDinosaur commented Jun 21, 2023

Relies on: nitrictech/nitric#467 to then bump the nitric version.
Can be reviewed but not merged

@tjholm
Copy link
Member

tjholm commented Jun 22, 2023

Can you rebase this onto the preview features branch? This will allow us to release HTTP proxies as a preview feature in the CLI initially.

@HomelessDinosaur HomelessDinosaur force-pushed the http-support branch 2 times, most recently from 420e961 to b5c13c6 Compare June 26, 2023 00:32
@tjholm
Copy link
Member

tjholm commented Jun 27, 2023

LGTM, let's get the dependencies updated once the core functionality is released on the core repo.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 10.46% and project coverage change: -0.42 ⚠️

Comparison is base (471ddbd) 27.44% compared to head (ed76f24) 27.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #528      +/-   ##
===========================================
- Coverage    27.44%   27.03%   -0.42%     
===========================================
  Files           26       26              
  Lines         1694     1753      +59     
===========================================
+ Hits           465      474       +9     
- Misses        1201     1251      +50     
  Partials        28       28              
Flag Coverage Δ
unittests 27.03% <10.46%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/codeconfig/function.go 0.00% <0.00%> (ø)
pkg/codeconfig/server.go 0.00% <0.00%> (ø)
pkg/codeconfig/uprequest.go 0.00% <0.00%> (ø)
pkg/codeconfig/codeconfig.go 36.96% <56.25%> (+0.84%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HomelessDinosaur HomelessDinosaur marked this pull request as ready for review June 28, 2023 01:40
@davemooreuws
Copy link
Member

A couple of issues:

  • on hot reload, ports keep incrementing
  • not found paths should return 404
  • nitric run does not seem to work with a connection refused error (double check)

All this was tested on windows 11 with latest node rc

HomelessDinosaur and others added 2 commits June 30, 2023 13:56
@tjholm tjholm merged commit 0c7c1c6 into develop Jul 4, 2023
5 of 7 checks passed
@HomelessDinosaur HomelessDinosaur deleted the http-support branch July 4, 2023 05:34
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants