-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add http proxy support #528
Conversation
34fe736
to
e7d9803
Compare
Can you rebase this onto the preview features branch? This will allow us to release HTTP proxies as a preview feature in the CLI initially. |
420e961
to
b5c13c6
Compare
LGTM, let's get the dependencies updated once the core functionality is released on the core repo. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #528 +/- ##
===========================================
- Coverage 27.44% 27.03% -0.42%
===========================================
Files 26 26
Lines 1694 1753 +59
===========================================
+ Hits 465 474 +9
- Misses 1201 1251 +50
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
A couple of issues:
All this was tested on windows 11 with latest node rc |
Co-authored-by: Tim Holm <tim.holm@nitric.io>
a98e122
to
7f44f9b
Compare
🎉 This PR is included in version 1.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Relies on: nitrictech/nitric#467 to then bump the nitric version.
Can be reviewed but not merged