Json parse error on weird module id's

[ELadner]

Occasionally the toolset generates bizarre module id's that don't convert both ways with the tools. Converting from GFF -> JSON works fine. Ths error occurs when converting back to GFF.

Error: unhandled exception: ./ifo/module.ifo.json(2693, 19) Error: { expected [JsonParsingError]

  "Mod_ID": {
    "type": "void",
    "value": "ÿÿÿÿ^A^@^@^@^@^@^@^@ã^A^@^@"
  },

That's /////wEAAAAAAAAA4wEAAA== in base64 or the binary below:

11111111 11111111 11111111 11111111 
00000001 00000000 00000000 00000000 
00000000 00000000 00000000 00000000 
11100011 00000001 00000000 00000000

[ELadner]

This happens occasionally on weird non-printable color tags, too, I think.

[niv]

This might be an issue with the json library. It really should escape these things. Hmm.

Regardless, Mod_ID is unused so as a quick workaround you can just strip it out.

[niv]

Can you retry on nim 0.19.4, which was released today? Or will you require binaries?

Edit: It might require re-generating module.ifo.json from gff.

[ELadner]

I can grab the latest nim, sure.

…

On Mon, Feb 4, 2019 at 4:23 PM niv ***@***.***> wrote: Can you retry on nim 0.19.4, which was released today? Or will you require binaries? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgtql7f6q4PcYNL2jdYzUaZnPLcRwBHks5vKLLJgaJpZM4af3Y3> .

-- Eric Ladner

[ELadner]

Same.. Don't know if it would make a difference, but I had to compile the tools by hand with the --nilseqs:on arg passed to nim becasue of a nil string handling issue in the system.nim library. $ nim --version Nim Compiler Version 0.19.4 [Linux: amd64] Compiled at 2019-02-01 Copyright (c) 2006-2018 by Andreas Rumpf git hash: b6d96cafc8bcad1f3d32f2910b25cd11a93f7751 active boot switches: -d:release $ nwn_gff --version | grep Version Version: master (316c05) # Example json file was extracted from a fresh module and converted to json with the new nwn_gff, also. $ nwn_gff -i module.ifo.json -o /tmp/module.ifo.json Error: unhandled exception: module.ifo.json(2693, 19) Error: { expected [JsonParsingError]

…

On Tue, Feb 5, 2019 at 6:21 AM Eric Ladner ***@***.***> wrote: I can grab the latest nim, sure. On Mon, Feb 4, 2019 at 4:23 PM niv ***@***.***> wrote: > Can you retry on nim 0.19.4, which was released today? Or will you > require binaries? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#4 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ADgtql7f6q4PcYNL2jdYzUaZnPLcRwBHks5vKLLJgaJpZM4af3Y3> > . > -- Eric Ladner

-- Eric Ladner

[niv]

Gah. Can you send me the failing .ifo file, please? To my work email is fine if you don't want to post it here publicly.

[ELadner-cvx]

the e-ix.net address? I'll send something tonight.

[ELadner]

module_ifo.zip

Attached is a test module that has a similar issue (module and JSON produced by nwn_gff)

[niv]

Should be fixed as of 1.3.1