Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8 vector linz class extension #12

Merged
merged 15 commits into from
Aug 17, 2021
Merged

8 vector linz class extension #12

merged 15 commits into from
Aug 17, 2021

Conversation

rosepearson
Copy link
Collaborator

@rosepearson rosepearson commented Aug 17, 2021 •
edited by Pooja3894
Loading

Clean up the vector.Linz class before using it as a template for downloading vector data from LRIS.

Changes:

  • Allow the class to be used to download all features in a layer if no search polygon is specified
  • Try default the LINZ 'geometry_names' in turn if no 'geometry_name' is specified
  • Add a test for downloading all feature values (i.e. no search polygon)
  • Add a test for not specifying the 'geometry_name' - add to existing test.

@rosepearson
Two changes to vector.Linz class. 1. Support returning the entire fea…
439a627 
…ture without filtering within a polygon region, 2. Try the default LINZ geometry_name's if none is specified
@rosepearson
Renamed geometry_type to 'geometry_name' as this is the term used in …
e63831f 
…the api responses'
@rosepearson rosepearson linked an issue Aug 17, 2021 that may be closed by this pull request
Automatically determine the cql_filter BBox(XXX, <- geometry type AND Remove catchment_polygon requirement from vector.Linz #8
Closed
@rosepearson rosepearson added this to the 0.1.1 milestone Aug 17, 2021
@rosepearson rosepearson marked this pull request as ready for review August 17, 2021 01:27
@rosepearson
Copy link
Collaborator Author

Hi @Pooja3894 this PR contains changes to the vector.Linz class that I would like to make before I use the Linz class as the starting point for a new Lris class for downloading from LRIS. I think a code review is probably sufficient + checking that I have added enough new tests to maintain test coverage

@rosepearson rosepearson added the enhancement New feature or request label Aug 17, 2021
@rosepearson rosepearson merged commit de1eae5 into main Aug 17, 2021
@rosepearson rosepearson deleted the 8-vector-Linz-class-extension branch August 17, 2021 04:27
@rosepearson rosepearson linked an issue Sep 12, 2021 that may be closed by this pull request
Publish V1 on PyPI #6
Closed
6 tasks
@rosepearson rosepearson removed a link to an issue Sep 12, 2021
Publish V1 on PyPI #6
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pooja3894 Pooja3894 Pooja3894 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.1
2 participants
@rosepearson @Pooja3894