Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a generic WFS query class and added tests to test it on the LRI… #22

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Added a generic WFS query class and added tests to test it on the LRI… #22

merged 2 commits into from
Sep 21, 2021

Conversation

rosepearson
Copy link
Collaborator

@rosepearson rosepearson commented Sep 20, 2021 •
edited
Loading

Make a generic WFS query class that can be used for any WFS based data service:

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings
    • Wiki

@rosepearson
Copy link
Collaborator Author

Thanks for the review @Pooja3894 - good to hear tests were passing locally on your machine. merging now :)

@rosepearson rosepearson merged commit 674463c into main Sep 21, 2021
@rosepearson rosepearson deleted the 21-generic-WFS branch September 21, 2021 23:34
@rosepearson rosepearson linked an issue Sep 22, 2021 that may be closed by this pull request
add a generic WFS class - so the user can specify the URL and geometry types at instantiation #21
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pooja3894 Pooja3894 Pooja3894 approved these changes

Assignees

@Pooja3894 Pooja3894

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a generic WFS class - so the user can specify the URL and geometry types at instantiation
2 participants
@rosepearson @Pooja3894