Enable tests on Windows #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub recently switched their free-tier runners (Standard GitHub-hosted runners) to new VMs which support nested virtualization. The change was announced on 2024-01-17.
nzbr
force-pushed
the
nested-virtualization
branch
4 times, most recently
from
36f0c00
to
5e96c6f
Compare
|
I'm gonna merge this into another branch on nix-community, so that I don't have to constantly push to your repo while I try to get this to work |
nzbr
force-pushed
the
nested-virtualization
branch
from
b7df7a4
to
353c56e
Compare
|
No problem. FYI, I recently learned from some YouTube video that GitHub makes all PRs available as hidden refs in the repository. So you don't have to add the fork as a remote to checkout a PR. However, I think you cannot push to these refs, so it wouldn't have helped you in this case. The refs are named like EDIT: Here is some official documentation about this feature: Checking out pull requests locally - GitHub Docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub recently upgraded their free-tier runners (Standard GitHub-hosted runners).
https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/
The new VMs support nested virtualization, although it is not documented in the blog post. This draft enables the tests on Windows, but not all of them are working.
sudo nixos-rebuild switchseems to hang in various tests for some reason.docker/docker.Tests.ps1fails. Here are the first two statements from the output:See also my last run. I don't really have time to figure out how to fix it. Anyway, I thought you might still be interested to know.