Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on Windows #430

Merged
merged 1 commit into from
May 6, 2024

Conversation

JojOatXGME
Copy link
Contributor

@JojOatXGME JojOatXGME commented Feb 29, 2024

GitHub recently upgraded their free-tier runners (Standard GitHub-hosted runners).
https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/

The new VMs support nested virtualization, although it is not documented in the blog post. This draft enables the tests on Windows, but not all of them are working.

  1. sudo nixos-rebuild switch seems to hang in various tests for some reason.
  2. docker/docker.Tests.ps1 fails. Here are the first two statements from the output:
    invalid pointererror: builder for '/nix/store/pq20h6rhjkndrl1x4d7rm63ahl62hb6j-nixos-23.11.drv' failed due to signal 11 (Segmentation fault)
    error: program '/nix/store/vgncjxxj6vfzynnh0si7c67466m1sm37-nix-2.18.1/bin/nix-env' failed with exit code 100
    

See also my last run. I don't really have time to figure out how to fix it. Anyway, I thought you might still be interested to know.

GitHub recently switched their free-tier runners (Standard GitHub-hosted
runners) to new VMs which support nested virtualization. The change was
announced on 2024-01-17.
@nzbr nzbr force-pushed the nested-virtualization branch 4 times, most recently from 36f0c00 to 5e96c6f Compare May 3, 2024 03:23
@nzbr nzbr changed the base branch from main to windows-tests May 6, 2024 16:06
@nzbr
Copy link
Member

nzbr commented May 6, 2024

I'm gonna merge this into another branch on nix-community, so that I don't have to constantly push to your repo while I try to get this to work

@nzbr nzbr marked this pull request as ready for review May 6, 2024 16:10
@nzbr nzbr merged commit 954de48 into nix-community:windows-tests May 6, 2024
15 checks passed
@JojOatXGME
Copy link
Contributor Author

JojOatXGME commented May 6, 2024

No problem.

FYI, I recently learned from some YouTube video that GitHub makes all PRs available as hidden refs in the repository. So you don't have to add the fork as a remote to checkout a PR. However, I think you cannot push to these refs, so it wouldn't have helped you in this case. The refs are named like refs/pull/430/head.

EDIT: Here is some official documentation about this feature: Checking out pull requests locally - GitHub Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants