Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: let's see what breaks with boot.initrd.systemd.enable #108

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 11, 2023

don't merge

@Mic92 Mic92 changed the title wip: let's see what breaks with systemd.enable wip: let's see what breaks with boot.initrd.systemd.enable Jan 11, 2023
@lilyinstarlight
Copy link
Member

I know you're not looking to merge this, but as a quick note: systemd-initrd does not quite yet have correct initrd fs/disk dependencies, because systemd does not respect /sysroot in the fstab as needing the related root fs targets and nixos does not yet set root= on the kernel cmdline because it breaks other things (until the next systemd release where they have been fixed)

I don't know that the failures are really related to that, but it does make the occasional spooky problem with initrd ordering happen and so we should wait on at least NixOS/nixpkgs#208269 before turning it on for any real tests

(I'm sorry if you were already aware, since I know you're just trying to do a quick how-much-might-break test here and it's not the most relevant bit of info)

@ElvishJerricco
Copy link

@lilyinstarlight while I broadly agree, I will also note that I don't see anything that should cause failures like we're seeing here. So we've definitely got some bugs to squash.

@jackinloadup
Copy link

jackinloadup commented Feb 21, 2023

NixOS/nixpkgs/pull/208269 was merged :-)

@lilyinstarlight
Copy link
Member

NixOS/nixpkgs/pull/208269 was merged :-)

With minor modifications, it looks like most disko tests work with systemd-initrd, but the mdadm tests still do not because of NixOS/nixpkgs#210210. So we'll still need that fixed before we can do a test matrix or something with systemd-initrd both on and off for all tests. But we could enable it for a handful of tests now I suppose, if we really wanted to

@Mic92
Copy link
Member Author

Mic92 commented Feb 21, 2023

rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants