Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: categorize builders like translators #151

Closed
wants to merge 3 commits into from

Conversation

yusdacra
Copy link
Member

This gives builders types like translators, namely ifd and pure. I implemented this similar to how translators are done.

@DavHau
Copy link
Member

DavHau commented May 20, 2022

I actually thought about removing the directory layer pure impure and instead express the properties via some flag inside the translator or builder file. Traversing through deep directory structures is annoying with nix.

@yusdacra
Copy link
Member Author

I actually thought about removing the directory layer pure impure and instead express the properties via some flag inside the translator or builder file. Traversing through deep directory structures is annoying with nix.

Yeah, I agree 😅. Do you want me to try taking a shot at that for both translators and builders?

@DavHau
Copy link
Member

DavHau commented May 20, 2022

Yeah, I agree sweat_smile. Do you want me to try taking a shot at that for both translators and builders?

Yes, that would be amazing. Eventually we should load all our module types the same way, so we can have a sane extension interface for all types of modules.

@DavHau
Copy link
Member

DavHau commented May 20, 2022

related: #135

@jaen
Copy link
Contributor

jaen commented May 20, 2022

Also related: #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants