Initialize nixos module system. (translators only) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusdacra
requested changes
Aug 14, 2022
- this fixes breakages triggered by the nixos modules system
DavHau
force-pushed
the
translator-modules
branch
from
d18263d
to
debe2e9
Compare
- add documentation to the subsystem-loading interface - expose evaled modules publicly via `framework` - add option config.modules to allow users to include their own modules - update examples for extending dream2nix
yusdacra
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initializes the structure for a potentially fully nixos modules based dream2nix framework.
For now only the translators and some related functionality is migrated as a test to allow for reviews.
In the future, further functionality could/should be migrated to
/src/modules.Why we want this?:
Concerning the file structure:
The idea is that
/src/modulesis a flat structure of directories. It should be easy to find the source of an option definition by knowing the option attribute path.For example the option
functions.translators.{something}can be found in/src/modules/functions.translatorsEvery file in
/src/modules/{category}should contain aninterface.nixand animplementation.nix.This should make it easy to quickly find the interface definition as a contributor.
Transition phase:
With this, now the framework is a mix of nixos-modules and not nixos-modules. That is a bit ugly, but we have no better way other than slowly transitioning to the new structure, and letting both old and new structure access each other.
Currently the nixos modules pieces, can access the old non-module pieces by using the specialArgs
dlibandcallPackageDream.The non nixos-modules pieces can access the modules via the
frameworkattribute which is brought in scope viacallPackageDream.@yusdacra It would be great if you could review this since you had implemented the current custom module loading logic.
Now is the time to really optimize the new structure, before we decide to move more stuff over.
@infinisil In case you have time to have a quick look at this, it would be great. If not, don't worry.