Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dream-lock: support multiple top-level packages #80

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented Feb 9, 2022

This changes the structure of the dream-lock.json to support a list of top level packages instead of a single top level package.
Despite these changes, some parts of the framework still depend on defaultPackage not being null or unset.
That means there is still some work left to, but from here on we can smoothly transition away from enforcing a defaultPackage.

removed dream-lock fields:

  • translator (currently covered by translatorParams)
  • translatedBy (currently covered by translatorParams)
  • mainPackageName
  • mainPackageVersion

added dream-lock fields:

  • defaultPackage (equivalent to old mainPackageName)
  • packages

Other changes done on the rust subsytem:

  • fix a bug in the rust translator where the path path-like sources was wrong whenever the path length is greater 1.
    (example ripgrep).
  • process only one input directory (scenarios with several input dirs are not yet really supported by the framework and this will be refined through Architecture: Project Discovery #76 anyways)

@yusdacra Could you review the rust changes?

Copy link
Member

@yusdacra yusdacra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rust changes look fine to me! One minor thing, the example specification for Rust subsystem should be updated as well to remove the packages field.

@DavHau DavHau merged commit 8e13d69 into main Feb 10, 2022
@DavHau DavHau deleted the dream-lock-packages branch June 24, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants