narinfo: more validation + underlying data structures #12

flokli · 2021-04-11T16:57:07Z

This teaches go-nix how to parse signature lines and checksums, and provides the parsed version them it in the NarInfo.

For this to work, the hash.Hash and nar.narinfo.Signature structs, surrounding functions and corresponding tests were introduced.

There's also a path package now, which provides some basic sanity-checking for store paths.

Together with the nar.narinfo.NarInfo.Validate()function, this provides some pretty good coverage in checking for invalid.narinfo` files.

Instead of returning strings, which need to be parsed again, return a struct containing the key name and digest. This also takes care of nixbase64 decoding/encoding.

hash/hash.go

nar/narinfo/validate.go

path/nixpath.go

This adds a Hash struct, holding HashType and Digest []byte, and provides functions to parse from and output a "nix-style" hash string. Co-Authored-By: edef <edef@edef.eu>

This just being called test.go won't execute the test - which is why this error wasn't spotted.

This provides some more sanity checking, and ensures hashes are in an easy-to consume format.

This adds functions to parse and render nix paths. Co-Authored-By: edef <edef@edef.eu>

This provides some more sanity checking on parsed .narinfo files, ensuring the paths in StorePath, References and Deriver are syntactically valid when no compression is present, ensuring File{Hash,Size} and Nar{Hash,Size} are equal This is also added to the narinfo unit test, ensuring our example narfile passes the validation.

nameRe isn't really used anywhere else currently, so this can be skipped.

flokli · 2021-04-12T17:54:31Z

Thanks for the review! I addressed all the remarks.

//nar/narinfo: parse signature lines

6f1a2d8

Instead of returning strings, which need to be parsed again, return a struct containing the key name and digest. This also takes care of nixbase64 decoding/encoding.

flokli requested a review from zimbatm April 11, 2021 16:57