Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: xplr: cfg.plugins does not work for more than one plugin #4520

Closed
2 tasks done
ChanceHarrison opened this issue Oct 2, 2023 · 2 comments · Fixed by #4521
Closed
2 tasks done

bug: xplr: cfg.plugins does not work for more than one plugin #4520

ChanceHarrison opened this issue Oct 2, 2023 · 2 comments · Fixed by #4521
Assignees
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@ChanceHarrison
Copy link
Contributor

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

The implementation of programs.xplr.plugins does not correctly set the package.path in the Lua configuration file that gets written out.

The result is that users cannot enable/load any additional plugins after the first.


For the full context, please reference this discussion on the upstream repository.

Maintainer CC

@NotAShelf

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.1.49, NixOS, 23.11 (Tapir), 23.11.20230830.a63a64b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - nixpkgs: `/nix/store/flsqq53kqi52lz73n543wmxz0mbhpb52-source`
@ChanceHarrison ChanceHarrison added bug triage Issues or feature request that have not been triaged yet labels Oct 2, 2023
Copy link

stale bot commented Jan 1, 2024

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Jan 1, 2024
@NotAShelf
Copy link
Contributor

not stale, PR stil needs merging

@stale stale bot removed the status: stale label Jan 2, 2024
fufexan pushed a commit to fufexan/home-manager that referenced this issue Feb 24, 2024
Fixes #nix-community#4520

Co-authored-by: Arijit Basu <11632726+sayanarijit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants