fish: allow arguments to functions #1063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Mar 1, 2020
This allows the ability to provide arguments to a function, such as `--on-event` in order to trigger a function on the `fish_command_not_found` event, for example.
|
@cole-h Thanks for the contribution! @Jomik, @ryanorendorff, mind having a quick look at this change? I don't know anything about fish. |
rycee
pushed a commit
that referenced
this pull request
Mar 7, 2020
This allows the ability to provide arguments to a function, such as `--on-event` in order to trigger a function on the `fish_command_not_found` event, for example. PR #1063
|
I'll merge for now. Can always fix any issue later. Many thanks for the contribution! Rebased to master in a11cf1d. |
jorsn
pushed a commit
to jorsn/home-manager
that referenced
this pull request
Apr 25, 2020
This allows the ability to provide arguments to a function, such as `--on-event` in order to trigger a function on the `fish_command_not_found` event, for example. PR nix-community#1063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the ability to provide arguments to a function, such as
--on-eventin order to trigger a function on thefish_command_not_foundevent, for example.The main reason for this was so that I could change
__fish_command_not_found_handlerbecause, on Arch, it looks for anypackages that might contain the misspelled binary. Previously, you might
have been able to get away with a hack like specifying the flags in the
function name, but now all you need to do is specify the submodule and
desired flags.
I added a test and news for this, but is there any better way to
document the available options? As it stands, I believe any interested
parties would need to browse the source to find out what is available
and what isn't.
I formatted themapAttrs'block withnixfmt, but it looks reallyugly. I left as-is because the fish module hasn't been blacklisted in
the format script yet, but it would look better if I went back and
manually formatted it.
Finally, please let me know if anything is not ideal, or is bad Nix, or
whatever. I'm still new to the language and stumbling around, but
interested in becoming more comfortable with it.
(Special thanks to @d-goldin for pointing me in the right direction)