New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alacritty: add CSIu support #1676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
bfd5913
to
d5bbdd1
Compare
@berbiche Thank you for your review, could you have a look again? Please feel free to directly amend this PR if you have an idea to encode those CSIu datapoints into a generic module that could be re-utilized across terminals (that support it). |
rationale and spec at http://www.leonerd.org.uk/hacks/fixterms/
d5bbdd1
to
e8d69af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is blocking: divnix/digga#51 |
@blaggacao can you add a simple test case where the user has enabled CSIu support while using their own keybindings? (i.e. The merging should work fine but it's always nice to have a test case for this! |
Thank you for your contribution! I marked this pull request as stale due to inactivity. If this remains inactive for another 7 days, I will close this PR. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the issue
|
Description
Add CSIu support for alacritty
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
. (fails unrelated on my machine)Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.