Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alacritty: add CSIu support #1676

Closed
wants to merge 1 commit into from

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Dec 23, 2020

Description

Add CSIu support for alacritty

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all. (fails unrelated on my machine)

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

modules/programs/alacritty.nix Outdated Show resolved Hide resolved
modules/programs/alacritty.nix Outdated Show resolved Hide resolved
@blaggacao
Copy link
Contributor Author

@berbiche Thank you for your review, could you have a look again? Please feel free to directly amend this PR if you have an idea to encode those CSIu datapoints into a generic module that could be re-utilized across terminals (that support it).

berbiche
berbiche previously approved these changes Dec 29, 2020
Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blaggacao
Copy link
Contributor Author

This is blocking: divnix/digga#51

@berbiche
Copy link
Member

@blaggacao can you add a simple test case where the user has enabled CSIu support while using their own keybindings? (i.e. CSIuSupport = true; and programs.alacritty.settings.key_bindings = [ { .... } ];.

The merging should work fine but it's always nice to have a test case for this!

@stale
Copy link

stale bot commented Jun 15, 2021

Thank you for your contribution! I marked this pull request as stale due to inactivity. If this remains inactive for another 7 days, I will close this PR. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously, when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the issue

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jun 15, 2021
@stale stale bot closed this Jun 22, 2021
@blaggacao blaggacao mentioned this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants