Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Always create profile directories #2035

Merged
merged 1 commit into from May 26, 2021

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented May 24, 2021

Description

If a profile is made but with not attributes set. e.g.

    profiles.Foo = {
      id = 0;
      isDefault = true;
    };

then

[Profile0]
Default=1
IsRelative=1
Name=Foo
Path=Foo

is written into {firefoxConfigPath}/profiles.ini
but no Foo dir is created in firefoxConfigPath

This causes Firefox to throw an error at runtime and make it unusable.

This makes the dir regardless.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@rycee
Copy link
Member

rycee commented May 24, 2021

Thanks! Looks OK to me. Just please follow the commit message guidelines: https://nix-community.github.io/home-manager/index.html#sec-commit-style

Something like perhaps

firefox: always create profile directories

[more description wrapped at ~72 chars]

@Rosuavio Rosuavio force-pushed the fix-empty-ff-profile branch 2 times, most recently from b617995 to 88c133b Compare May 24, 2021 22:19
@Rosuavio Rosuavio marked this pull request as ready for review May 24, 2021 22:19
@Rosuavio Rosuavio requested a review from rycee as a code owner May 24, 2021 22:19
@Rosuavio
Copy link
Contributor Author

@rycee, it should be good now!

@Rosuavio Rosuavio changed the title Write .keep file into firefox profile for each profile regardless of any other settings. Firefox: Always create profile directories May 24, 2021
Write ".keep" file in profile dir for each profile regardless of any
other settings to creare profile dir.
@rycee rycee merged commit b840707 into nix-community:master May 26, 2021
@rycee
Copy link
Member

rycee commented May 26, 2021

Thanks! Merged to master now. I squashed the commits and fixed the commit message (there must be an empty line between the subject and the descriptive text).

@Rosuavio Rosuavio deleted the fix-empty-ff-profile branch May 26, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants