vscode: avoid unnecessary IFD #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
peterhoeg
pushed a commit
to peterhoeg/home-manager
that referenced
this pull request
Nov 29, 2021
1 task
ncfavier
added a commit
to ncfavier/home-manager
that referenced
this pull request
Jul 15, 2022
Fixed in nix-community#2506 then unfixed in nix-community#2613
5 tasks
ncfavier
added a commit
to ncfavier/home-manager
that referenced
this pull request
Jul 22, 2022
Fixed in nix-community#2506 then unfixed in nix-community#2613
rycee
pushed a commit
to ncfavier/home-manager
that referenced
this pull request
Jul 27, 2022
Fixed in nix-community#2506 then unfixed in nix-community#2613
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
Fixed in nix-community#2506 then unfixed in nix-community#2613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can avoid doing an import from derivation for extensions that have a
vscodeExtUniqueIdattribute (i.e. the extensions generated bybuildVscodeExtension), which should be the excruciating majority of extensions people use.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.