Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: remove git overlay in tests #2629

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

berbiche
Copy link
Member

Description

See #2628 (comment)

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@berbiche
Copy link
Member Author

berbiche commented Jan 11, 2022

And now notmuch is broken on unstable... Great!

edit: NixOS/nixpkgs#154309

@rycee rycee merged commit 8a5550a into nix-community:master Jan 11, 2022
@rycee
Copy link
Member

rycee commented Jan 11, 2022

Yeah, maybe have to disable those tests meanwhile?

rycee added a commit that referenced this pull request Jan 11, 2022
This disables a few tests that fail due to a broken notmuch in
Nixpkgs. See

    #2629

and

    NixOS/nixpkgs#154309
@berbiche berbiche deleted the fix/gh-git-overlay branch January 11, 2022 16:37
teto pushed a commit to teto/home-manager that referenced this pull request Jan 20, 2022
This disables a few tests that fail due to a broken notmuch in
Nixpkgs. See

    nix-community#2629

and

    NixOS/nixpkgs#154309
Austreelis pushed a commit to Austreelis/home-manager that referenced this pull request Jan 26, 2022
This disables a few tests that fail due to a broken notmuch in
Nixpkgs. See

    nix-community#2629

and

    NixOS/nixpkgs#154309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants