-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waybar: fix command not found when reloading #2865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Once #2867 is merged, you will have to rebase your changes to fix the failing tests. |
@berbiche Sorry for the delay, I've rebased the changes now 😄 |
Looks like the test needs to be fixed. It also needs |
👍 though coreutils is very likely already part of the test closure. |
@sumnerevans |
In that case, there's no need for a stub 👍 |
Used |
Fixed formatting. |
Description
Currently, trying to run
systemctl --user reload waybar.service
fails with:Fixed this by inserting the full path to the
kill
command from thebusybox
package.Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
(Extra:) Code tested on a live system.