Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh-agent: init module #4178

Merged
merged 2 commits into from
Jul 1, 2023
Merged

ssh-agent: init module #4178

merged 2 commits into from
Jul 1, 2023

Conversation

lheckemann
Copy link
Contributor

Description

Add a simple module for ssh-agent, fixes #1087.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}

{long description}

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

@lheckemann lheckemann mentioned this pull request Jun 28, 2023
Closed
sumnerevans
sumnerevans requested changes Jun 29, 2023
View reviewed changes
modules/lib/maintainers.nix Outdated Show resolved Hide resolved
modules/modules.nix Show resolved Hide resolved
modules/services/ssh-agent.nix Outdated Show resolved Hide resolved
@lheckemann
Copy link
Contributor Author

Applied all your suggestions, thanks!

sumnerevans
sumnerevans requested changes Jun 30, 2023
View reviewed changes
modules/misc/news.nix Outdated Show resolved Hide resolved
@sumnerevans
Copy link
Member

Is there any reason to keep this as a draft? I personally would like to get this in.

@lheckemann lheckemann marked this pull request as ready for review July 1, 2023 13:38
sumnerevans
sumnerevans approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this manually, since both commits need to end up on master separate from one another, and creating a whole separate PR just for the typo change seems excessive.

@sumnerevans sumnerevans merged commit 89d10f8 into nix-community:master Jul 1, 2023
3 checks passed
@lheckemann lheckemann deleted the ssh-agent branch July 1, 2023 20:56
olmokramer
olmokramer reviewed Jul 2, 2023
View reviewed changes
modules/misc/news.nix

{
time = "2023-06-30T14:46:22+00:00";
condition = config.services.ssh-agent.enable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this will now only render the news item for people that already have the service enabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I assume this is a mistake. My guess is that it should be condition = hostPlatform.isLinux; and the module itself should contain

assertions = [
  (lib.hm.assertions.assertPlatform "services.ssh-agent" pkgs lib.platforms.linux)
];

since it is Linux-only.

@sumnerevans sumnerevans mentioned this pull request Jul 7, 2023
Merged
6 tasks
sumnerevans added a commit that referenced this pull request Jul 7, 2023
@sumnerevans
ssh-agent: add assertion and fix news entry
398867f 
See #4178 (comment)

Signed-off-by: Sumner Evans <me@sumnerevans.com>
rycee pushed a commit that referenced this pull request Jul 10, 2023
@sumnerevans
ssh-agent: add assertion and fix news entry (#4210)
a6d1d95 
See #4178 (comment)

Signed-off-by: Sumner Evans <me@sumnerevans.com>
antholeole pushed a commit to antholeole/home-manager that referenced this pull request Jul 24, 2023
@lheckemann
ssh-agent: init module (nix-community#4178)
26d7326
antholeole pushed a commit to antholeole/home-manager that referenced this pull request Jul 24, 2023
@sumnerevans
ssh-agent: add assertion and fix news entry (nix-community#4210)
1492fbc 
See nix-community#4178 (comment)

Signed-off-by: Sumner Evans <me@sumnerevans.com>
@kachick kachick mentioned this pull request Aug 10, 2023
Closed
SimSaladin added a commit to SimSaladin/home-manager that referenced this pull request Aug 26, 2023
@SimSaladin
Merge remote-tracking branch 'upstream/master' into develop
532f650 
* upstream/master: (352 commits)
  flake.lock: Update
  qcal: add module
  bat: generate cache file in XDG cache home
  nixos: only refer to `users.users` if needed
  home-cursor: remove IFD when linking icon directories
  flake.lock: Update
  home-cursor: improve icon compatibility
  fix(qt): allow theming for apps started by systemd (nix-community#4349)
  flake.lock: Update
  fcitx5: add `fcitx5-config-qt` to test stub
  pqiv: only run tests on Linux platforms
  pqiv: add module
  Translate using Weblate (German)
  xplr: add module
  browserpass: support librewolf
  Translate using Weblate (Romanian)
  Translate using Weblate (Portuguese (Brazil))
  hyprland: remove xwayland.hidpi (nix-community#4302)
  home-manager: handle profile list in Nix >2.17
  lf: simplify option validation (nix-community#4334)
  programs.khal: uncomment locale config (nix-community#4319)
  kanshi: support adaptive sync (nix-community#4328)
  mu: add package option (nix-community#4325)
  modules: types.string throws error now (nix-community#4324)
  taffybar: Avoid restarting too quickly (nix-community#4316)
  aerc: do not use smtp-starttls (nix-community#4272)
  zsh: Add `zsh.history.ignoreAllDups` config option (nix-community#4248)
  jujutsu: fix zsh completion (nix-community#4305)
  Translate using Weblate (Korean)
  Translate using Weblate (Romanian)
  Translate using Weblate (German)
  flake.lock: Update
  network-manager-applet: remove `--sm-disable` flag
  himalaya: update a link to ticket
  nushell: deprecation of let-env (nix-community#4292)
  man: fix caches generation in cross-compiled system (nix-community#4294)
  fish: fix session vars build in cross-compiled system (nix-community#4293)
  Update translation files
  Translate using Weblate (Chinese (Simplified))
  gh: option to enable helper for additional hosts (nix-community#4288)
  home-manager: rework news command
  home-manager: skip manual in uninstall configuration
  gnome-terminal: add assertion on profile names
  hyprland: use `toKeyValue`'s `indent` argument (nix-community#4274)
  gpg: fix typo (nix-community#4277)
  firefox: make package nullable (nix-community#4113)
  git-sync: add news entry for darwin
  tmate: don't generate empty config file (nix-community#4271)
  gh-dash: add module
  git-sync: add darwin support
  flake.lock: Update
  hyprland: prioritize variables and beziers (nix-community#4263)
  hyprland: add module
  script-directory: fix documentation link (nix-community#4258)
  Translate using Weblate (Indonesian)
  Translate using Weblate (Ukrainian)
  Translate using Weblate (Spanish)
  Translate using Weblate (Swedish)
  docs: hide `_module.*` from NixOS/nix-darwin docs
  jujutsu: update for Jujutsu 0.8.0 (nix-community#4250)
  ripgrep: don't set env. variable if no config (nix-community#4254)
  docs: update for Markdown migration
  treewide: remove now-redundant `lib.mdDoc` calls
  docs: clean up after Markdown migration
  flake: remove temporary nixpkgs pin
  treewide: convert all option docs to Markdown
  treewide: adjust some DocBook for conversion
  treewide: `mkAliasOption` -> `mkAliasOptionMD`
  treewide: `mkPackageOption` -> `mkPackageOptionMD`
  treewide: convert options with tables to Markdown
  treewide: convert options with lists to Markdown
  treewide: convert custom `enable` docs to Markdown
  treewide: convert parameterized docs to Markdown
  treewide: manually convert some docs to Markdown
  treewide: fix `mkEnableOption` arguments
  treewide: add missing option descriptions
  docs: use `nixosOptionsDoc`
  flake: temporarily pin nixpkgs version
  version: add `isReleaseBranch`
  manual: add test
  Update translation files
  flake.lock: Update
  home-manager: remove Home Manager default paths
  imapnotify: Use JSON type for extraConfig (nix-community#4238)
  Translate using Weblate (French)
  zsh: fix custom syntax highlighting styles (nix-community#4236)
  i3-sway: allow arbitrary floating modifier (nix-community#4229)
  i3-sway: multiple outputs (nix-community#4223)
  home-cursor.nix: enable gtk module when enabling gtk config generation (nix-community#4144)
  aerc: add assertion to limit per-account extraConfig to UI config (nix-community#4196)
  flake.lock: Update
  ssh-agent: add assertion and fix news entry (nix-community#4210)
  imapnotify: move test
  imapnotify: use direct nix store path for config
  flake.lock: Update
  nushell: add login.nu configuration option
  himalaya: fix notmuch backend
  swayosd: add module
  pyenv: add module
  darcs: add module
  tests: some minor cleanups
  goimapnotify: remove test dependency on notmuch
  unison: Allow using same option multiple times (nix-community#4208)
  imapnotify: Add launchd agent (nix-community#3291)
  i3: remove deprecated example in i3.config.startup (nix-community#4201)
  antidote: static file move to /tmp
  Translate using Weblate (Indonesian)
  PULL_REQUEST_TEMPLATE.md: add maintainer cc section (nix-community#4193)
  programs.khal
  vdirsyncer: synchronize metadata as well (nix-community#4167)
  i18n: Use glibcLocales from NixOS if possible (nix-community#2333) (nix-community#4177)
  xfconf: remove properties with null values (nix-community#4192)
  home-manager: Use `path:` URI type for flake default (nix-community#3646)
  ci: autolabel calendars PRs (nix-community#4165)
  flake.lock: Update (nix-community#4161)
  news: fix typo in programs.zsh.antidote entry
  ssh-agent: init module (nix-community#4178)
  chromium: fix `commandLineArgs` to use the user specified package (nix-community#4175)
  sxhkd: allow usage of derivations as keybind commands (nix-community#4169)
  README: Remove the pills (nix-community#4181)
  lsd: use -A instead of -a in aliases (nix-community#4173)
  kakoune: add defaultEditor option
  docs: update link to allowed users setting (nix-community#4176)
  zsh: allow setting custom syntax highlighting styles (nix-community#4122)
  flake: add formatter (nix-community#3620)
  broot: fix test (nix-community#4170)
  antidote: fix .dot path
  ci: build manual and push to home-manager.dev
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee left review comments

@olmokramer olmokramer olmokramer left review comments

@sumnerevans sumnerevans sumnerevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for starting ssh-agent?
4 participants
@lheckemann @sumnerevans @rycee @olmokramer